Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split write and ingest throughput #4245

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Split write and ingest throughput #4245

merged 1 commit into from
Mar 14, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Mar 14, 2022 •
edited
Loading

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: close #4243

Problem Summary: Now the "Write Throughput By Instance" panel mixes the throughput of write and ingest, which is not easy to check whether the write throughput of each instance is balanced or not. And is not easy to check when we are scaling-in or scaling-out TiFlash instance.

What is changed and how it works?

  • Split "write" and "ingest" into different lines in "Write Throughput By Instance"
  • Rename "throughput_write" to "throughput_write+ingest" in "Write & Delta Management Throughput" to indicate that include "write" and "ingest" explicitly. Cause we care about foreground write and background delta-management is matched or not in that panel.

Scale-in one node and scale-out another node
Before this PR
image

After this PR
image
image

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Make the Grafana panel "Write Throughput By Instance" more explicitly

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2022
@JaySon-Huang JaySon-Huang self-assigned this Mar 14, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2022
@flowbehappy flowbehappy self-requested a review March 14, 2022 05:35
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b740b7a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTunnel.h                            8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Storages/Transaction/SchemaBuilder.cpp         835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          844               803     4.86%          55                51     7.27%        1045               973     6.89%         488               468     4.10%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16853      9456             43.89%    189607  95861        49.44%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

@JaySon-Huang
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot merged commit 2a94905 into pingcap:master Mar 14, 2022
@JaySon-Huang JaySon-Huang deleted the split_write_ingest_throughput branch March 14, 2022 07:38
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
@JaySon-Huang @ywqzzy
Split write and ingest throughput (pingcap#4245)
8e3938a 
close pingcap#4243

Signed-off-by: ywqzzy <[email protected]>
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
@ywqzzy
update.
b54dece 
Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

Split write and ingest throughput (pingcap#4245)

close pingcap#4243

Signed-off-by: ywqzzy <[email protected]>

fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224)

close pingcap#4146

Signed-off-by: ywqzzy <[email protected]>

PageStorage: Fix some bugs (pingcap#4212)

ref pingcap#3594

Signed-off-by: ywqzzy <[email protected]>

Make test of CreateTables using affected opts (pingcap#4239)

close pingcap#4235

Signed-off-by: ywqzzy <[email protected]>

BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247)

ref pingcap#3594

Signed-off-by: ywqzzy <[email protected]>

support `PartitionTableScan` in TiFlash (pingcap#3876)

close pingcap#3873

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

support last_day and dayofmonth pushdown to tiflash (pingcap#4183)

close pingcap#4149

Signed-off-by: ywqzzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the throughput of write and ingest in "Write Throughput By Instance"
5 participants
@JaySon-Huang @ti-chi-bot @sre-bot @flowbehappy @lidezhu